-
-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix async schema #1382
Fix async schema #1382
Conversation
🦋 Changeset detectedLatest commit: 0e0fb85 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
The latest changes of this PR are available as alpha in npm (based on the declared
|
✅ Benchmark Results
|
setSchema(schema$); | ||
} | ||
}, | ||
onExecute() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the idea here is to defer execution until the schema is set - But that will still let validation fail 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's why I left this PR draft :D because only if you don't do validate
you can use promises for schema
.
@saihaj closing this one in favor of your PRs |
No description provided.