Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useLazyLoadedSchema #1483

Closed
Tracked by #1358
n1ru4l opened this issue Aug 16, 2022 · 2 comments
Closed
Tracked by #1358

Remove useLazyLoadedSchema #1483

n1ru4l opened this issue Aug 16, 2022 · 2 comments
Assignees
@saihaj
Milestone
v3

Comments

@n1ru4l
Copy link
Owner

n1ru4l commented Aug 16, 2022 •
edited
Loading

This was a mistake from the beginning as we cannot async set the schema (validate and parse) are sync functions.
@n1ru4l n1ru4l added this to the v3 milestone Aug 16, 2022
@theguild-bot theguild-bot mentioned this issue Aug 20, 2022
Closed
@saihaj saihaj self-assigned this Sep 1, 2022
@saihaj
Copy link
Collaborator

saihaj commented Sep 1, 2022

I guess we also should remove useAsyncSchema since there is nothing async about it 🤔

@n1ru4l
Copy link
Owner Author

n1ru4l commented Sep 2, 2022 •
edited
Loading

@saihaj yes let's remove it, it is borken by design

also related (to be closed)

@saihaj saihaj mentioned this issue Sep 2, 2022
Merged
@saihaj saihaj closed this as completed Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saihaj saihaj

Labels
None yet
Projects
None yet
Milestone
v3
Development

No branches or pull requests
2 participants
@n1ru4l @saihaj