Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept NumpadEnter as Enter #171

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Accept NumpadEnter as Enter #171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#![deny(missing_docs)]
#![warn(missing_docs)]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you revert this change please? Other than that, looks good to me. Thanks!

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the second thought, I guess it'll make CI fail anyway. Let's keep it then :)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see. It seems like the new Bevy version breaks CI as its macro generates a struct without documentation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could #![allow(missing_docs)]? See SO thread. Not too sure how to exclude a single derive macro from the missing docs, there's some forum posts here, but it looks messy and might only work for proc macros.

Could allow and wait for bevy to write their docs.


//! This crate provides a [Egui](https://github.com/emilk/egui) integration for the [Bevy](https://github.com/bevyengine/bevy) game engine.
//!
Expand Down
1 change: 1 addition & 0 deletions src/systems.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,6 +444,7 @@ fn bevy_to_egui_key(key_code: KeyCode) -> Option<egui::Key> {
KeyCode::Tab => egui::Key::Tab,
KeyCode::Back => egui::Key::Backspace,
KeyCode::Return => egui::Key::Enter,
KeyCode::NumpadEnter => egui::Key::Enter,
KeyCode::Space => egui::Key::Space,
KeyCode::Insert => egui::Key::Insert,
KeyCode::Delete => egui::Key::Delete,
Expand Down