Accept NumpadEnter as Enter #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cs to warn instead of deny.
mvlabat
requested changes
Apr 2, 2023
| @@ -1,4 +1,4 @@ | |||
| #![deny(missing_docs)] | |||
| #![warn(missing_docs)] | |||
There was a problem hiding this comment.
Could you revert this change please? Other than that, looks good to me. Thanks!
There was a problem hiding this comment.
On the second thought, I guess it'll make CI fail anyway. Let's keep it then :)
There was a problem hiding this comment.
Oh I see. It seems like the new Bevy version breaks CI as its macro generates a struct without documentation.
There was a problem hiding this comment.
We could #![allow(missing_docs)]? See SO thread. Not too sure how to exclude a single derive macro from the missing docs, there's some forum posts here, but it looks messy and might only work for proc macros.
Could allow and wait for bevy to write their docs.
mvlabat
approved these changes
Apr 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a single line of code added to be able to use NumpadEnter. See Issue #170.
To get this to compile I did have to change the level of
missing_docsas the compiler complains of theWorldQueryderive macro being undocumented. See bevy Issue #3492, the cratebevy_ecs_macrosis not yet documented enough. Once that is fixed, then the level of documentation can go back up todeny(under a separate PR).