Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[code-infra] Fix @mui/internal-test-utils screen export type #43150

Merged
merged 2 commits into from
Aug 2, 2024
Merged

[code-infra] Fix @mui/internal-test-utils screen export type #43150

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01e79d3
[code-infra] Fix `@mui/internal-test-utils` `screen` export type
LukasTy Aug 2, 2024
48be57c
add explicit type
LukasTy Aug 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages-internal/test-utils/src/createRenderer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -740,5 +740,5 @@ function act<T>(callback: () => void | T | Promise<T>) {
const bodyBoundQueries = within(document.body, { ...queries, ...customQueries });

export * from '@testing-library/react/pure';
export { act, cleanup, fireEvent };
export const screen: Screen = { ...rtlScreen, ...bodyBoundQueries };
export { act, fireEvent };
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleanup is already exported on L742 above.
I don't see the need to duplicate/override the export. 🤷

export const screen: Screen & typeof bodyBoundQueries = { ...rtlScreen, ...bodyBoundQueries };