[code-infra] Fix @mui/internal-test-utils screen export type
#43150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-43150--material-ui.netlify.app/ Bundle size report |
LukasTy
commented
Aug 2, 2024
| @@ -740,5 +740,5 @@ function act<T>(callback: () => void | T | Promise<T>) { | |||
| const bodyBoundQueries = within(document.body, { ...queries, ...customQueries }); | |||
|
|
|||
| export * from '@testing-library/react/pure'; | |||
| export { act, cleanup, fireEvent }; | |||
| export const screen: Screen = { ...rtlScreen, ...bodyBoundQueries }; | |||
| export { act, fireEvent }; | |||
There was a problem hiding this comment.
cleanup is already exported on L742 above.
I don't see the need to duplicate/override the export. 🤷
aarongarciah
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #42968.
Fix issues in: mui/mui-x#14002.
P.S. Tested locally that a package built on this PR fixes the TS issue.