Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs-infra] Remove display: flex from SectionTitle #42979

Merged
merged 1 commit into from
Jul 17, 2024
Merged

[docs-infra] Remove display: flex from SectionTitle #42979

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/mui-docs/src/MarkdownElement/MarkdownElement.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,6 @@ const Root = styled('div')(
boxShadow: 'none',
fontWeight: 'inherit',
position: 'relative',
display: 'flex',
alignItems: 'center',
Comment on lines -177 to -178
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any why these attributes have been added in? 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not manage to find when exactly we added it, because of the migration to the @mui/docs which pertubate the git blame

From what I remember, we struggled to have nice vertical alignment between the "anchor link", "comment link", and the title constent. But seems it's working well. So I suspect a DOM modification we did and forgot to remove this display flex

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying. 👌
Hopefully, this doesn't break some other sections that we are not aware of. 🙈

userSelect: 'text',
},
'& .anchor-icon': {
Expand Down
Loading