[docs-infra] Remove display: flex from SectionTitle
#42979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-42979--material-ui.netlify.app/ Bundle size report |
LukasTy
commented
Jul 17, 2024
Comment on lines
-177
to
-178
| display: 'flex', | ||
| alignItems: 'center', |
There was a problem hiding this comment.
Do you have any why these attributes have been added in? 🤔
There was a problem hiding this comment.
I do not manage to find when exactly we added it, because of the migration to the @mui/docs which pertubate the git blame
From what I remember, we struggled to have nice vertical alignment between the "anchor link", "comment link", and the title constent. But seems it's working well. So I suspect a DOM modification we did and forgot to remove this display flex
There was a problem hiding this comment.
Thanks for clarifying. 👌
Hopefully, this doesn't break some other sections that we are not aware of. 🙈
alexfauquette
approved these changes
Jul 17, 2024
joserodolfofreitas
pushed a commit
to joserodolfofreitas/material-ui
that referenced
this pull request
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created from: mui/mui-x#13543 (comment)
Example in MUI Core
Before
https://next.mui.com/material-ui/migration/v5-style-changes/#%E2%9C%85-update-makestyles-import
After
https://deploy-preview-42979--material-ui.netlify.app/material-ui/migration/v5-style-changes/#%E2%9C%85-update-makestyles-import