Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs-infra][toolpad] Fix Page title and SERP title mismatch #41919

Merged
merged 5 commits into from
May 16, 2024
Merged

[docs-infra][toolpad] Fix Page title and SERP title mismatch #41919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
588c8ba
fix: Page title and SERP title mismatch
bharatkashyap Apr 16, 2024
c14ab82
fix: More reuse
bharatkashyap Apr 16, 2024
2c1aa9a
fix: Alex review
bharatkashyap May 8, 2024
da58bbd
Merge branch 'next' of github.com:mui-org/material-ui into fix/ahrefs
bharatkashyap May 8, 2024
4cecbf5
fix: Olivier review
bharatkashyap May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 5 additions & 15 deletions docs/src/modules/components/AppLayoutDocs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,21 @@ import { useRouter } from 'next/router';
import { styled } from '@mui/material/styles';
import { exactProp } from '@mui/utils';
import GlobalStyles from '@mui/material/GlobalStyles';
import { pathnameToLanguage } from 'docs/src/modules/utils/helpers';
import Head from 'docs/src/modules/components/Head';
import AppFrame from 'docs/src/modules/components/AppFrame';
import AppContainer from 'docs/src/modules/components/AppContainer';
import AppTableOfContents from 'docs/src/modules/components/AppTableOfContents';
import AdManager from 'docs/src/modules/components/AdManager';
import AppLayoutDocsFooter from 'docs/src/modules/components/AppLayoutDocsFooter';
import BackToTop from 'docs/src/modules/components/BackToTop';
import getProductInfoFromUrl from 'docs/src/modules/utils/getProductInfoFromUrl';
import {
AD_MARGIN_TOP,
AD_HEIGHT,
AD_HEIGHT_MOBILE,
AD_MARGIN_BOTTOM,
} from 'docs/src/modules/components/Ad';
import { convertProductIdToName } from 'docs/src/modules/components/AppSearch';

const TOC_WIDTH = 242;

Expand Down Expand Up @@ -119,20 +120,9 @@ export default function AppLayoutDocs(props) {
throw new Error('Missing description in the page');
}

const { canonicalAs } = pathnameToLanguage(router.asPath);
let productName = 'MUI';
if (canonicalAs.startsWith('/material-ui/')) {
productName = 'Material UI';
} else if (canonicalAs.startsWith('/base-ui/')) {
productName = 'Base UI';
} else if (canonicalAs.startsWith('/x/')) {
productName = 'MUI X';
} else if (canonicalAs.startsWith('/system/')) {
productName = 'MUI System';
} else if (canonicalAs.startsWith('/toolpad/')) {
productName = 'Toolpad';
} else if (canonicalAs.startsWith('/joy-ui/')) {
productName = 'Joy UI';
const productName = convertProductIdToName(getProductInfoFromUrl(router.asPath));
if (!productName) {
console.error('productName mapping missing for', router.asPath);
}

const Layout = disableLayout ? React.Fragment : AppFrame;
Expand Down
1 change: 1 addition & 0 deletions docs/src/modules/components/AppSearch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,7 @@ const productNameProductId = {
toolpad: 'Toolpad',
'toolpad-studio': 'Toolpad Studio',
'toolpad-core': 'Toolpad Core',
'docs-infra': 'Docs Infra',
};

export function convertProductIdToName(productInfo) {
Expand Down
Loading