[docs-infra][toolpad] Fix Page title and SERP title mismatch #41919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharatkashyap
added
the
website
Netlify deploy previewhttps://deploy-preview-41919--material-ui.netlify.app/ Bundle size report |
| import { | ||
| AD_MARGIN_TOP, | ||
| AD_HEIGHT, | ||
| AD_HEIGHT_MOBILE, | ||
| AD_MARGIN_BOTTOM, | ||
| } from 'docs/src/modules/components/Ad'; | ||
| import { convertProductIdToName } from './AppSearch'; |
There was a problem hiding this comment.
Avoid the relative imports. It's creating issues with other repository reusing the code
Comment on lines
123
to
124
| let productName = 'MUI'; | ||
| if (canonicalAs.startsWith('/material-ui/')) { | ||
| productName = 'Material UI'; | ||
| } else if (canonicalAs.startsWith('/base-ui/')) { | ||
| productName = 'Base UI'; | ||
| } else if (canonicalAs.startsWith('/x/')) { | ||
| productName = 'MUI X'; | ||
| } else if (canonicalAs.startsWith('/system/')) { | ||
| productName = 'MUI System'; | ||
| } else if (canonicalAs.startsWith('/toolpad/')) { | ||
| productName = 'MUI Toolpad'; | ||
| } else if (canonicalAs.startsWith('/joy-ui/')) { | ||
| productName = 'Joy UI'; | ||
| } | ||
| productName = convertProductIdToName(getProductInfoFromUrl(router.asPath)); |
There was a problem hiding this comment.
Much cleaner, but this does not support fall back to MUI. The convertProductIdToName will return undefined for unknown id.
const productNameProductId = {
'material-ui': 'Material UI',
'joy-ui': 'Joy UI',
'base-ui': 'Base UI',
x: 'MUI X',
system: 'MUI System',
toolpad: 'Toolpad',
'toolpad-studio': 'Toolpad Studio',
'toolpad-core': 'Toolpad Core',
};
export function convertProductIdToName(productInfo) {
return (
productNameProductId[productInfo.productId] ||
productNameProductId[productInfo.productCategoryId]
);
}
There was a problem hiding this comment.
but this does not support fall back to MUI.
Should it throw instead? Helping catch bugs sooner, I imagine we will never use "MUI" for a docs page. For https://next--material-ui.netlify.app/experiments/docs/headers/, we might need to have "Docs infra" productId to name conversion.
oliviertassinari
changed the title
oliviertassinari
changed the title
oliviertassinari
added
bug 🐛
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
alexfauquette
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A step toward finishing the renaming of "MUI Toolpad" to "Toolpad".
The issue is visible from the 12 April Ahrefs audit: