[material-ui][PaginationItem] Deprecate components prop

[sai6855]

part of #41279

• I have followed (at least) the PR section of the contributing guide.

[mui-bot]

Netlify deploy preview

• docs/data/material/migration/migrating-from-deprecated-apis/migrating-from-deprecated-apis.md

Pagination: parsed: +2.74% , gzip: +2.57%
PaginationItem: parsed: +2.86% , gzip: +2.65%
packages/material-ui/material-ui.production.min.js: parsed: +0.08% , gzip: +0.12%
@material-ui/core: parsed: +0.07% , gzip: +0.07%
@material-ui/lab: parsed: +0.13% , gzip: +0.12%

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 606f8c3

[sai6855]

Below tests are not removed , because describeConformance test suite is not customizable enough to handle PaginationItem.

material-ui/packages/mui-material/src/PaginationItem/PaginationItem.test.js

Lines 29 to 31 in 73c88b6

	'slotsProp',
	'slotPropsProp',
	'slotPropsCallback', // not supported yet

I see 2 inconsistencies in PaginationItem compare to other components.

1. properties in components prop are always started in capital letter in other components but in PaginationItem it starts with small letter
2. if slot is passed through components prop or slots prop it is guranteed to get rendered but in PaginationItem it's not guranteed that passed slot will be displayed as type prop should be equal to passed slot.

Due to these inconsistencies following tests are not passed ( there are many more, i didn't listed all) on removing slotsProp, slotPropsProp, slotPropsCallback from skip array

material-ui/packages/test-utils/src/describeConformance.tsx

Line 365 in 73c88b6

[capitalize(slotName)]: slotComponent,

material-ui/packages/test-utils/src/describeConformance.tsx

Line 408 in 73c88b6

[capitalize(slotName)]: ComponentForComponentsProp,

[DiegoAndai]

Hey @sai6855, thanks for working on this!

Regarding the tests, would removing testLegacyComponentsProp: true (here) fix this issue so we can stop skipping the slots tests?

[sai6855]

fix this issue so we can stop skipping the slots tests?

No, it didn't helped. even on removing testLegacyComponentsProp: true tests are failing.

[DiegoAndai]

Even on removing testLegacyComponentsProp: true tests are failing.

I see. Some tests can be fixed by removing testLegacyComponentsProp: true, but others are failing because the rendering of slots is conditional to the type: https://github.com/mui/material-ui/pull/41777/files#diff-014e80cab0c8e6df4ca350c7fd91d2d7b490250af715108435ed9113e1886216R413-R418

So slots are not always rendered, as describeConformance expects. @siriwatknp do you know of any other case of slots being rendered conditionally? If it's common enough we could cover it in describeConformance, otherwise, we can cover the slots testing in PaginationItem tests.

[sai6855]

otherwise, we can cover the slots testing in PaginationItem tests.

@DiegoAndai shall i go ahead with this approach?

[DiegoAndai]

@DiegoAndai shall i go ahead with this approach?

Yes, let's do it. It makes sense to me to cover this custom case separately.

Let's add a comment pointing out that the slots tests are covered outside of describeConformance because of this.

[sai6855]

@DiegoAndai added tests to test conditional slots

[DiegoAndai]

Thanks for updating the tests @sai6855, I have a couple of follow-up comments. Let me know what you think 😊

[DiegoAndai]

Great job @sai6855!