Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][StepConnector] deprecate composed classes #41740

Merged
merged 7 commits into from
Apr 10, 2024

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Apr 2, 2024

@sai6855 sai6855 added component: stepper This is the name of the generic UI component, not the React module! deprecation New deprecation message package: material-ui Specific to @mui/material docs Improvements or additions to the documentation labels Apr 2, 2024
@mui-bot
Copy link

mui-bot commented Apr 2, 2024

@sai6855 sai6855 marked this pull request as draft April 2, 2024 05:54
@sai6855 sai6855 force-pushed the deprecate-step-connector-classes branch from 9bccdfb to 3c7f5c3 Compare April 4, 2024 04:48
@sai6855 sai6855 marked this pull request as ready for review April 4, 2024 05:39
@sai6855 sai6855 requested a review from DiegoAndai April 4, 2024 05:39
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Apr 9, 2024
@DiegoAndai
Copy link
Member

I'm not sure what happened when fixing conflicts that caused the CI to break, looking into it...

@DiegoAndai DiegoAndai force-pushed the deprecate-step-connector-classes branch from 1861152 to 3c7f5c3 Compare April 9, 2024 19:40
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Apr 9, 2024
@DiegoAndai
Copy link
Member

I'm stuck 😅. @mui/code-infra do you know what might have happened with the codesandbox build? It broke after I resolved some conflicts by merging next into this branch. Reverting the merge didn't solve the problem.

@sai6855 sai6855 force-pushed the deprecate-step-connector-classes branch from 0e93d2c to 3bb5211 Compare April 10, 2024 03:58
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 10, 2024
@sai6855 sai6855 force-pushed the deprecate-step-connector-classes branch from 3bb5211 to 3c7f5c3 Compare April 10, 2024 04:01
Signed-off-by: sai chand <60743144+sai6855@users.noreply.github.com>
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 10, 2024
@sai6855
Copy link
Contributor Author

sai6855 commented Apr 10, 2024

I'm stuck 😅. @mui/code-infra do you know what might have happened with the codesandbox build? It broke after I resolved some conflicts by merging next into this branch. Reverting the merge didn't solve the problem.

@mui/code-infra BTW codesandbox build is failing in other PR's too, not just this.

#41767
#41782
#41777

@michaldudak
Copy link
Member

It's an issue on the Codesandbox side. They're working on a fix.

@DiegoAndai DiegoAndai merged commit ae45647 into mui:next Apr 10, 2024
22 checks passed
@sai6855 sai6855 deleted the deprecate-step-connector-classes branch April 11, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: stepper This is the name of the generic UI component, not the React module! deprecation New deprecation message docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants