Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pigment-css][material-ui] Render badge demos #41353

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Mar 4, 2024

A follow-up from #40213 which is a part of #41273.

image

@mui-bot
Copy link

mui-bot commented Mar 4, 2024

Netlify deploy preview

https://deploy-preview-41353--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against d6aea59

@brijeshb42
Copy link
Contributor

I was not able to run the demos without adding @pigmentcss/react as a peer dep in material-ui. Did you encounter a similar issue ?

@siriwatknp
Copy link
Member Author

siriwatknp commented Mar 4, 2024

I was not able to run the demos without adding @pigmentcss/react as a peer dep in material-ui. Did you encounter a similar issue ?

What error did you encounter?

Here is the steps that works for me:

  1. at root: pnpm install && pnpm build
  2. cd apps/pigment-next-app && pnpm install && pnpm dev

@siriwatknp siriwatknp changed the title [pigmentcss][material-ui] Render badge demos [pigment-css][material-ui] Render badge demos Mar 4, 2024
@siriwatknp siriwatknp merged commit fff0501 into mui:master Mar 5, 2024
20 checks passed
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: pigment-css Specific to @pigment-css/*
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants