Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Badge] Use the variants API in the styled call #40213

Merged
merged 9 commits into from
Dec 25, 2023

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova commented Dec 15, 2023

This PR converts the Badge component to use the variants API in order to be compatible with the zero-runtime CSS in JS library syntax. No breaking changes were found during the migration.

@mnajdova mnajdova added component: badge This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material proof of concept Studying and/or experimenting with a to be validated approach labels Dec 15, 2023
@mui-bot
Copy link

mui-bot commented Dec 15, 2023

Netlify deploy preview

https://deploy-preview-40213--material-ui.netlify.app/

@material-ui/core: parsed: +0.09% , gzip: +0.08%

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 28780ce

@mnajdova mnajdova marked this pull request as ready for review December 20, 2023 10:30
@mnajdova
Copy link
Member Author

I am merging, no harm in having it done Let's see if there will be some unexpected reported issues around it.

@mnajdova mnajdova merged commit 546ad5e into mui:master Dec 25, 2023
19 checks passed
mnajdova added a commit to mnajdova/material-ui that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: badge This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material proof of concept Studying and/or experimenting with a to be validated approach
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants