-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RadioButton] Allow customising icons #3285
Conversation
Oh i just noticed. checkbox is using |
I think we should deprecate. |
Yeah I agree 😆 |
@@ -30,6 +32,13 @@ const RadioButtonExampleSimple = () => ( | |||
disabled={true} | |||
style={styles.radioButton} | |||
/> | |||
<RadioButton | |||
value="ludicrous" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I was thinking it might not be a bad idea. without it there is no way to demonstrate how a disabled checked version would look like. Maybe I should add a disabled checked one? Or you think it's ok if we don't demonstrate that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking it might not be a bad idea.
I thought it was a mistake.
Maybe I should add a disabled checked one
What about add it to the second RadioButtonGroup
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'll also add one for the checkbox too, is that ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we can have one RadioButton
in the first RadioButtonGroup
with a custom checkedIcon
and a unique value.
Then one disabled RadioButton
in the second RadioButtonGroup
that is selected by default.
f694c32
to
21b0078
Compare
@oliviertassinari Take another look please 😁 |
@alitaheri Awesome 👍. |
[RadioButton] Allow customising icons
thanks 😁 |
Continuation of #1639.
This PR also tries to clean up the code for this component as well.
And rename checkbox's
unCheckedIcon
touncheckedIcon
And update the docs.