Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RadioButton] Allow customising icons #3285

Merged
merged 1 commit into from
Feb 11, 2016

Conversation

alitaheri
Copy link
Member

Continuation of #1639.

This PR also tries to clean up the code for this component as well.

And rename checkbox's unCheckedIcon to uncheckedIcon

And update the docs.

@alitaheri
Copy link
Member Author

Oh i just noticed. checkbox is using unChecked where I'm using unchecked should I go against English and change this or should we deprecate that?

@mbrookes
Copy link
Member

I think we should deprecate. unChecked is unNatural. 😏

@alitaheri
Copy link
Member Author

Yeah I agree 😆

@@ -30,6 +32,13 @@ const RadioButtonExampleSimple = () => (
disabled={true}
style={styles.radioButton}
/>
<RadioButton
value="ludicrous"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to change the value:
capture d ecran 2016-02-10 a 20 15 08

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was thinking it might not be a bad idea. without it there is no way to demonstrate how a disabled checked version would look like. Maybe I should add a disabled checked one? Or you think it's ok if we don't demonstrate that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking it might not be a bad idea.

I thought it was a mistake.

Maybe I should add a disabled checked one

What about add it to the second RadioButtonGroup?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll also add one for the checkbox too, is that ok?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we can have one RadioButton in the first RadioButtonGroup with a custom checkedIcon and a unique value.
Then one disabled RadioButton in the second RadioButtonGroup that is selected by default.

@oliviertassinari oliviertassinari added PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI and removed PR: Needs Review labels Feb 10, 2016
@alitaheri alitaheri added PR: Needs Review and removed PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI labels Feb 11, 2016
@alitaheri
Copy link
Member Author

@oliviertassinari Take another look please 😁

@oliviertassinari
Copy link
Member

@alitaheri Awesome 👍.

oliviertassinari added a commit that referenced this pull request Feb 11, 2016
[RadioButton] Allow customising icons
@oliviertassinari oliviertassinari merged commit 70fa10b into mui:master Feb 11, 2016
@alitaheri alitaheri deleted the custom-radio-icons branch February 11, 2016 12:59
@alitaheri
Copy link
Member Author

thanks 😁

@zannager zannager added component: Icon The React component. component: button This is the name of the generic UI component, not the React module! labels Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: button This is the name of the generic UI component, not the React module! component: Icon The React component.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants