Allow customising RadioButton icons #1639
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danni
force-pushed
the
custom-radio-icons
branch
from
b27eea5
to
1f60ff0
Compare
JonatanGarciaClavo
pushed a commit
to JonatanGarciaClavo/material-ui
that referenced
this pull request
Sep 25, 2015
…hen you have input background hint can not see it.
JonatanGarciaClavo
pushed a commit
to JonatanGarciaClavo/material-ui
that referenced
this pull request
Sep 25, 2015
…hen you have input background hint can not see it.
JonatanGarciaClavo
pushed a commit
to JonatanGarciaClavo/material-ui
that referenced
this pull request
Sep 25, 2015
…hen you have input background hint can not see it.
| @@ -87,10 +91,22 @@ let RadioButton = React.createClass({ | |||
| this.props.iconStyle, | |||
| this.props.disabled && styles.fillWhenDisabled); | |||
|
|
|||
| let checkedElement = checkedIcon ? React.cloneElement(checkedIcon, { | |||
| style: this.mergeAndPrefix(onStyles, checkedIcon.props.style), | |||
| }) : React.createElement(RadioButtonOn, { | |||
There was a problem hiding this comment.
Could you keep the JSX syntax?
oliviertassinari
added
the
PR: needs revision
|
You will have to rebase. |
| @@ -15,9 +15,11 @@ let RadioButton = React.createClass({ | |||
| }, | |||
|
|
|||
| propTypes: { | |||
| checkedIcon: React.PropTypes.element, | |||
There was a problem hiding this comment.
I think that we should use node that is less restrictive.
Could you add this to the documentation?
|
Hi @danni, I'd like to merge this PR. Do you think you might be able to do the last bits of tidying up per @oliviertassinari's comments? I can take care of the docs separately. |
|
Being continued here: #3285 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is used the same way as for Checkbox.