[Card] Fix TypeScript not recognizing "component" prop #20093
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…graphyProps` contains a `component` prop (introduced on commit b6ff4f5 removing component as explicit prop).
Details of bundle changes.Comparing: 5fc9926...968b06b Details of page changes
|
rart
referenced
this pull request
Mar 13, 2020
eps1lon
requested changes
Mar 13, 2020
|
Thanks for the quick reply, @eps1lon 🙂
Agree. I was blindsided by my own build error 😅 Done! |
rart
changed the title
rart
changed the title
|
@eps1lon I added the fix to Restoring the prop, still seems to comply with the desired usage that motivated the change. Thoughts? @oliviertassinari @fyodore82 @eps1lon Like so: export interface TypographyTypeMap<P = {}, D extends React.ElementType = 'span'> {
props: P & {
// ...etc
component?: D;
};
defaultComponent: D;
classKey: TypographyClassKey;
}It used to be... export interface TypographyProps
extends StandardProps<React.HTMLAttributes<HTMLElement>, TypographyClassKey> {
// ...etc
component?: React.ElementType<React.HTMLAttributes<HTMLElement>>;
}Wondering also if there are concerns stopping this from getting processed and how can we help? After all this was an unintended breaking change. For the other affected members of the community who have shown some discomfort, whilst this is resolved unless you're specifically trying to use some of the latest release features, you may change you package.json to use exactly 4.7.2 (i.e. P.S. I think there is one or more raise condition(s) with the (automated) tests. I see them fail and succeed unexpectedly on this PR which doesn't involve any of the failed test. Feel free to see the commit history and inspect the failures. |
oliviertassinari
requested changes
Mar 15, 2020
fyodore82
reviewed
Mar 17, 2020
eps1lon
added
the
PR: out-of-date
oliviertassinari
added
the
component: card
oliviertassinari
changed the title
… (title & subheader)
…t' into fix-nested-typography-prop-component # Conflicts: # packages/material-ui/src/CardHeader/CardHeader.spec.tsx # packages/material-ui/src/ListItemText/ListItemText.spec.tsx
|
Apologies, guys. I sort messed up the rebase. So opened a new clean PR with this work. |
1 task
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, CardHeader breaks TypeScript compilation when
titleTypographyPropsorsubheaderTypographyPropscontains acomponentprop. In version v4.7.2, the below used to work:Somewhere after (4.8.3 o 4.9.5), TypeScript compilation for consumer apps (verified on TypeScript 3.8.3) broke due to a PR removing the component as an explicit prop of Typography.
Checking the release notes I didn't see this noted as a breaking change so I suspect this wasn't quite the idea.