[List] Fix component types of ListItemText

[fyodore82]

…aryTypographyProps

• [ v ] I have followed (at least) the PR section of the contributing guide.

fix #19036

[mui-pr-bot]

No bundle size changes comparing 10bc98f...67c6089

Generated by 🚫 dangerJS against 67c6089

[oliviertassinari]

@fyodore82 Could you have a look at the test fails? @eps1lon Is the pull request taking the right direction?

[fyodore82]

@oliviertassinari , I'll surely take a look and make correction next week, so tests will pass. I had no time yesterday so I left it as is.

[fyodore82]

Several comments for changes made.
I have removed Partial from primaryTypographyProps and secondaryTypographyProps for the following reasons:

1. All props of Typography are already optional
2. component prop is optional.
3. And the main reason, if component is used, OverrideProps will add component own props. Some components, especially custom, may have required props. With Partial all props, even required by custom component, will become optional which may introduce bugs. See line 23 of ListItemText.spec.tsx as example

[eps1lon]

Thank you for starting this effort. There are a lot of moving parts so reviewing this might take some time. First look is promising though

[rart]

Note this PR now addresses the underlying issue for all affected components at once (e.g. CardHeader is breaking too).

@eps1lon @fyodore82

[eps1lon]

Nice work. Just had to update the branch and made some stylistic changes.

[rart]

Whats the plan for CardHeader? It’s pretty much same issue. Is anyone working on that already? Happy to transfer this work to CardHeader if it helps. If there’s any special considerations let me know too. @eps1lon @fyodore82

[fyodore82]

@rart , yes, for CardHeader solution will be the similar.
I think you can transfer it. At least I am not working on CardHeader.

[oliviertassinari]

@rart 👍