-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Menu] Add new context menu demo #17839
Conversation
No bundle size changes comparing 5d564f9...6654246 |
A couple of minor issues from playing with the demo:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added a commit that focuses on minimizing the size of the demo. I think that are good. The final step for me would be to migrate the demo to TypeScript.
Also, @mercuriete has proposed to help test the component, do you think that you could have a look at https://deploy-preview-17839--material-ui.netlify.com/components/menus/#context-menu? Thanks.
updated
- removed useEffect - merged state into single object - removed extra className - changed id to 'context-menu' to keep it unique - changed description
Co-Authored-By: Matt <github@nospam.33m.co>
Co-Authored-By: Matt <github@nospam.33m.co>
Co-Authored-By: Josh Wooding <12938082+joshwooding@users.noreply.github.com>
Co-Authored-By: Josh Wooding <12938082+joshwooding@users.noreply.github.com>
519570e
to
6654246
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SarthakC As per your preference, I have migrated the demo to TypeScript.
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6654246:
|
@SarthakC First pull request ✌️, thank you, well done |
Cheers! |
Closes #1462