-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Context Menu #1462
Comments
I created a ContextMenu component that may suite your needs, if not it should provide a nice example of one. |
@rolandpoulter Thanks for sharing it with us 👍 👍 I'll have a look Would it be ok with you if we include your work in our repository? |
Yes! I would create a PR myself, just have to get around to it. |
@rolandpoulter Are you working on a PR for this? |
This comment has been minimized.
This comment has been minimized.
Does it supports nested ? |
+1 Would love to see a dedicated Context Menu component. The Popover component can be used, but it falls short in many areas in regards to what a context menu should do. |
I have a ContextMenu component in my repository. The Menu component from material-ui is used in it. Code: https://github.com/alex1kirch/material-ui-experiments/blob/master/src/decorators/contextMenu.tsx |
This comment has been minimized.
This comment has been minimized.
There is a paid version of the component in https://www.telerik.com/kendo-react-ui/components/layout/menu/context-menu/. |
Looking at the telerik component, it seems that all we need is a new demo with the Menu component, reopening. |
@oliviertassinari I tried out what @alex1kirch had in his demo, seems to work for me! |
@oliviertassinari I can't help on developing right now due to time constraint but I can help on testing if this ticket got implemented. |
Sorry I didn't see my mention on the PR I did a little test and It work on mobile and It works perfect. Thank you very much |
Hi im am trying to implement a context menu with this library.
to archive my goal, i used drop down menu inside a custom component that have a div with oncontextmenu handler wraping the childrens.
when a context menu is triggered i set the open state of the drop down menu and forceupdate to rerender from outside the component.
my problems were that every time that i right click on an element, this trigers an mouseup event as well.
finally i get something working good enough but i have some problems with tap events because i dont know if was a longtap or a regular tap event.
It would be nice that you implement a Context Menu component because DropDown is not created for this purpouses.
I think that this idea will be usefull for a lot of people because on mobile phones is natural to use context menus with a long tap or right click.
thank you in advance for this awsome product :)
The text was updated successfully, but these errors were encountered: