Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context Menu #1462

Closed
mercuriete opened this issue Aug 20, 2015 · 14 comments · Fixed by #17839
Closed

Context Menu #1462

mercuriete opened this issue Aug 20, 2015 · 14 comments · Fixed by #17839
Labels
component: menu This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation

Comments

@mercuriete
Copy link

Hi im am trying to implement a context menu with this library.

to archive my goal, i used drop down menu inside a custom component that have a div with oncontextmenu handler wraping the childrens.

when a context menu is triggered i set the open state of the drop down menu and forceupdate to rerender from outside the component.

my problems were that every time that i right click on an element, this trigers an mouseup event as well.

finally i get something working good enough but i have some problems with tap events because i dont know if was a longtap or a regular tap event.

It would be nice that you implement a Context Menu component because DropDown is not created for this purpouses.

I think that this idea will be usefull for a lot of people because on mobile phones is natural to use context menus with a long tap or right click.

thank you in advance for this awsome product :)

@rolandpoulter
Copy link
Contributor

rolandpoulter commented Jan 25, 2016

I created a ContextMenu component that may suite your needs, if not it should provide a nice example of one.
https://github.com/rolandpoulter/on-web-ui/blob/master/src/common/views/ContextMenu.js

@alitaheri alitaheri changed the title Feature Request: Context Menu Context Menu Jan 28, 2016
@alitaheri
Copy link
Member

@rolandpoulter Thanks for sharing it with us 👍 👍 I'll have a look

Would it be ok with you if we include your work in our repository?

@rolandpoulter
Copy link
Contributor

Yes! I would create a PR myself, just have to get around to it.

@aahan96
Copy link
Contributor

aahan96 commented Jun 10, 2016

@rolandpoulter Are you working on a PR for this?

@greysonp

This comment has been minimized.

@imerkle
Copy link

imerkle commented May 3, 2017

Does it supports nested ?

@mririgoyen
Copy link

+1 Would love to see a dedicated Context Menu component. The Popover component can be used, but it falls short in many areas in regards to what a context menu should do.

@alex1kirch
Copy link

alex1kirch commented Jul 12, 2018

I have a ContextMenu component in my repository. The Menu component from material-ui is used in it.

Code: https://github.com/alex1kirch/material-ui-experiments/blob/master/src/decorators/contextMenu.tsx

Example: https://mui-experiments.herokuapp.com/contextMenu

@oliviertassinari oliviertassinari added the component: menu This is the name of the generic UI component, not the React module! label Mar 13, 2019
@oliviertassinari

This comment has been minimized.

@oliviertassinari
Copy link
Member

There is a paid version of the component in https://www.telerik.com/kendo-react-ui/components/layout/menu/context-menu/.

@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 6, 2019

Looking at the telerik component, it seems that all we need is a new demo with the Menu component, reopening.

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation help appreciated and removed new feature New feature or request low priority labels Oct 6, 2019
@akphi
Copy link

akphi commented Oct 8, 2019

@oliviertassinari I tried out what @alex1kirch had in his demo, seems to work for me!

@mercuriete
Copy link
Author

@oliviertassinari
Hi, even though I am not working on that company that I worked on 2015, this use case is still valid.

I can't help on developing right now due to time constraint but I can help on testing if this ticket got implemented.
Thanks :)

@mercuriete
Copy link
Author

mercuriete commented Oct 18, 2019

Sorry I didn't see my mention on the PR

I did a little test and It work on mobile and It works perfect.

Thank you very much
:-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: menu This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

11 participants