Fixed DatePicker year/month navigation buttons #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Addresses #1075 |
| }, style); | ||
| }, | ||
| style, | ||
| {fill: this.state.hovered ? onColor : offColor}); // Make sure our fill color overrides fill provided in props.style |
There was a problem hiding this comment.
Just a small code formatting suggestion:
let mergedStyles = this.mergeAndPrefix({
display: 'inline-block',
height: 24,
width: 24,
userSelect: 'none',
transition: Transitions.easeOut(),
}, style, {
// Make sure our fill color overrides fill provided in props.style
fill: this.state.hovered ? onColor : offColor
});
There was a problem hiding this comment.
You got it, I'll make the change.
|
@hai-cea Updated the formatting. |
|
@jkruder Please rebase. |
…s.style. Also fixed zindex issue with the month/year.
|
@hai-cea Rebased. |
hai-cea
added a commit
that referenced
this pull request
Jul 9, 2015
Fixed DatePicker year/month navigation buttons
|
Thanks @jkruder |
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Nov 10, 2020
zannager
added
component: date picker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In svg-icons there was a command to delete the fill property from this.props.style. This is destructive behavior on something that should be treated as immutable. This issue presented itself as soon as I hovered over one of the year/month buttons in the DatePicker that was disabled.
Also fixed a z-indexing issue with the month year being displayed between the month/year buttons.