fix: remove performance cliff for glob extension regex

mrmlnc · Jan 7, 2022 · 4f5ff66 · 4f5ff66
1 parent 5669fab
commit 4f5ff66
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/utils/pattern.spec.ts b/src/utils/pattern.spec.ts
@@ -125,6 +125,7 @@ describe('Utils → Pattern', () => {
 
 			it('should return false for unfinished glob extension', () => {
 				assert.ok(!util.isDynamicPattern('@('));
+				assert.ok(!util.isDynamicPattern('@' + '('.repeat(999999) + 'a'));
 				assert.ok(!util.isDynamicPattern('@(a'));
 				assert.ok(!util.isDynamicPattern('@(a|'));
 				assert.ok(!util.isDynamicPattern('@(a|b'));

diff --git a/src/utils/pattern.ts b/src/utils/pattern.ts
@@ -11,7 +11,7 @@ const ESCAPE_SYMBOL = '\\';
 const COMMON_GLOB_SYMBOLS_RE = /[*?]|^!/;
 const REGEX_CHARACTER_CLASS_SYMBOLS_RE = /\[[^[]*]/;
 const REGEX_GROUP_SYMBOLS_RE = /(?:^|[^!*+?@])\([^(]*\|[^|]*\)/;
-const GLOB_EXTENSION_SYMBOLS_RE = /[!*+?@]\(.*\)/;
+const GLOB_EXTENSION_SYMBOLS_RE = /[!*+?@]\([^(]*\)/;
 const BRACE_EXPANSIONS_SYMBOLS_RE = /{[^,.{]*(?:,|\.\.)[^,.{]*}/;
 
 type PatternTypeOptions = {