fix: remove performance cliff for brace expransions regex

mrmlnc · Jan 7, 2022 · 5669fab · 5669fab
1 parent 3325450
commit 5669fab
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/utils/pattern.spec.ts b/src/utils/pattern.spec.ts
@@ -132,10 +132,14 @@ describe('Utils → Pattern', () => {
 
 			it('should return false for unfinished brace expansions', () => {
 				assert.ok(!util.isDynamicPattern('{'));
+				assert.ok(!util.isDynamicPattern('{'.repeat(999999)));
 				assert.ok(!util.isDynamicPattern('{a'));
 				assert.ok(!util.isDynamicPattern('{,'));
 				assert.ok(!util.isDynamicPattern('{a,'));
 				assert.ok(!util.isDynamicPattern('{a,b'));
+				assert.ok(!util.isDynamicPattern('{a' + ','.repeat(999999) + 'b'));
+				assert.ok(!util.isDynamicPattern('{1..'));
+				assert.ok(!util.isDynamicPattern('{1.' + '.'.repeat(999999) + '2'));
 			});
 		});
 

diff --git a/src/utils/pattern.ts b/src/utils/pattern.ts
@@ -12,7 +12,7 @@ const COMMON_GLOB_SYMBOLS_RE = /[*?]|^!/;
 const REGEX_CHARACTER_CLASS_SYMBOLS_RE = /\[[^[]*]/;
 const REGEX_GROUP_SYMBOLS_RE = /(?:^|[^!*+?@])\([^(]*\|[^|]*\)/;
 const GLOB_EXTENSION_SYMBOLS_RE = /[!*+?@]\(.*\)/;
-const BRACE_EXPANSIONS_SYMBOLS_RE = /{.*(?:,|\.\.).*}/;
+const BRACE_EXPANSIONS_SYMBOLS_RE = /{[^,.{]*(?:,|\.\.)[^,.{]*}/;
 
 type PatternTypeOptions = {
 	braceExpansion?: boolean;