Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle the "switchannotationeditorparams" event in the editor-code (issue 18196) #18605

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Handle the "switchannotationeditorparams" event in the editor-code (issue 18196) #18605

merged 2 commits into from
Aug 13, 2024

Commits on Aug 13, 2024

  1. Use the local eventBus in the AnnotationEditorUIManager constructor 

    This shortens the code ever so slightly, which cannot hurt.
    @Snuffleupagus
    Snuffleupagus committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    8273553 View commit details
    Browse the repository at this point in the history

  2. Handle the "switchannotationeditorparams" event in the editor-code (i… 

    …ssue 18196)

The problem seems to be caused by the browser trying to "restore" editing input-elements, in the various toolbars, to their previous values when the tab is re-opened.

Hence the simplest solution appears to be to move the event handling into the editor-code, which is also less code overall, since the listener thus won't be registered early enough for the problem to appear.
    @Snuffleupagus
    Snuffleupagus committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    9e0c6ef View commit details
    Browse the repository at this point in the history