Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the "switchannotationeditorparams" event in the editor-code (issue 18196) #18605

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

Snuffleupagus
Copy link
Collaborator

The problem seems to be caused by the browser trying to "restore" editor input-elements, in the various toolbars, to their previous values when the tab is re-opened.

Hence the simplest solution appears to be to move the event handling into the editor-code, which is also less code overall, since the listener thus won't be registered early enough for the problem to appear.

This shortens the code ever so slightly, which cannot hurt.
…ssue 18196)

The problem seems to be caused by the browser trying to "restore" editing input-elements, in the various toolbars, to their previous values when the tab is re-opened.

Hence the simplest solution appears to be to move the event handling into the editor-code, which is also less code overall, since the listener thus won't be registered early enough for the problem to appear.
@Snuffleupagus Snuffleupagus changed the title Handle the "switchannotationeditorparams" event in the editor-code (issue ) Handle the "switchannotationeditorparams" event in the editor-code (issue 18196) Aug 13, 2024
@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/5f5324cb8732ce6/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/5f5324cb8732ce6/output.txt

Total script time: 1.03 mins

Published

@Snuffleupagus
Copy link
Collaborator Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/d39133205183851/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/dcc1a50fe580c11/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/d39133205183851/output.txt

Total script time: 8.54 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/dcc1a50fe580c11/output.txt

Total script time: 18.26 mins

  • Integration Tests: FAILED

@timvandermeij timvandermeij merged commit 8446d3a into mozilla:master Aug 13, 2024
8 checks passed
@timvandermeij
Copy link
Contributor

I can confirm that the issue no longer happens. Thank you for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors shown in the web console after reopening a closed viewer tab
3 participants