Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce some duplication when toggling "expanded" buttons in the viewer toolbars #16410

Merged
merged 2 commits into from
May 11, 2023
Merged

Reduce some duplication when toggling "expanded" buttons in the viewer toolbars #16410

merged 2 commits into from
May 11, 2023

Commits on May 11, 2023

  1. Reduce some duplication when toggling "expanded" buttons in the viewe… 

    …r toolbars

This is very similar to PR 16281, but for buttons that use the "aria-expanded" attribute.
    @Snuffleupagus
    Snuffleupagus committed May 11, 2023
    Configuration menu
    Copy the full SHA
    362be76 View commit details
    Browse the repository at this point in the history

  2. Add the "aria-controls" attribute to the editor-toolbar buttons 

    Similar to other toolbar/secondaryToolbar buttons that open toolbars or dialogs, it seems reasonable to use "aria-controls" for the editor-toolbar buttons as well.
    @Snuffleupagus
    Snuffleupagus committed May 11, 2023
    Configuration menu
    Copy the full SHA
    0305b04 View commit details
    Browse the repository at this point in the history