Reduce some duplication when toggling "expanded" buttons in the viewer toolbars #16410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r toolbars This is very similar to PR 16281, but for buttons that use the "aria-expanded" attribute.
Similar to other toolbar/secondaryToolbar buttons that open toolbars or dialogs, it seems reasonable to use "aria-controls" for the editor-toolbar buttons as well.
Snuffleupagus
force-pushed
the
toggleExpandedBtn
branch
from
6b548fc
to
0305b04
Compare
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/6d4d3328cf34bbf/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/9cf3ce5e4ef4441/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/6d4d3328cf34bbf/output.txt Total script time: 3.59 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/9cf3ce5e4ef4441/output.txt Total script time: 12.39 mins
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very similar to PR #16281, but for buttons that use the "aria-expanded" attribute.