[api-minor] Update the minimum supported Node.js version to 18 #16293
Conversation
|
I'm in favor of doing this considering that Node 18 is the current LTS version (and for e.g. Firefox we also only support the current ESR version), the upcoming EOL date of Node 16 and the fact that we already updated to Node 18 in the CI as well some time ago in 588447a and didn't run into any issues. Moreover, it helps to remove compatibility code and a dependency, which is always good. |
|
My plan was actually to wait a little bit before submitting this for actual review, since we just increased the minimum supported Node.js version to
Part of the problem, w.r.t. the mentioned regressions, is that we only test in Node.js |
Snuffleupagus
force-pushed
the
Node-18
branch
4 times, most recently
from
e71e67c
to
f25134a
Compare
Snuffleupagus
force-pushed
the
Node-18
branch
3 times, most recently
from
7bfe5c5
to
9e9fd5b
Compare
Snuffleupagus
force-pushed
the
Node-18
branch
3 times, most recently
from
6c10e5f
to
f36eb83
Compare
This patch updates the minimum supported environments as follows: - Node.js 18, which was released on 2022-04-19; see https://en.wikipedia.org/wiki/Node.js#Releases Note also that Node.js 16 will soon reach EOL, and thus no longer receive any security updates.
…ntHandler` For some time these checks have only targeted Node.js environments, since the features in question exist in all supported browsers (even when a `legacy`-build is used). Now that we've updated the minimum supported Node.js version to 18, a number of polyfills are thus (finally) no longer necessary in that environment. Hence for certain *basic* functionality, such as e.g. text-extraction, it's now possible to use either a modern- or a `legacy`-build of the PDF.js library in Node.js environments. *Please note:* For e.g. canvas-rendering in Node.js environments it's still necessary to use a `legacy`-build, since that functionality requires various polyfills.
…one` Originally we only used the `structuredClone` polyfill in the `LoopbackPort`-implementation, and that obviously isn't used anywhere within the various image decoders. At this point in time we've started to use `structuredClone` a little bit more, hence it seems overall simpler to just bundle the polyfill even in the `legacy`-version of the IMAGE_DECODERS built-target.
Now that Node.js version 18 is required, we should be able to use `Array.prototype.at()` everywhere in the code-base.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/fc8532687eed3fe/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/fc8532687eed3fe/output.txt Total script time: 1.29 mins Published |
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b10b1469989df3f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/5df8ce00bf9347c/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/b10b1469989df3f/output.txt Total script time: 2.62 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/5df8ce00bf9347c/output.txt Total script time: 13.21 mins
|
|
Nice work; thanks! |
[api-minor] Update the minimum supported Node.js version to 18
This patch updates the minimum supported environments as follows:
Note also that Node.js 16 will soon reach EOL, and thus no longer receive any security updates.
Remove the compatibility checks in
WorkerMessageHandler.createDocumentHandlerFor some time these checks have only targeted Node.js environments, since the features in question exist in all supported browsers (even when a
legacy-build is used).Now that we've updated the minimum supported Node.js version to 18, a number of polyfills are thus (finally) no longer necessary in that environment. Hence for certain basic functionality, such as e.g. text-extraction, it's now possible to use either a modern- or a
legacy-build of the PDF.js library in Node.js environments.Please note: For e.g. canvas-rendering in Node.js environments it's still necessary to use a
legacy-build, since that functionality requires various polyfills.Remove the IMAGE_DECODERS special-case when polyfilling
structuredCloneOriginally we only used the
structuredClonepolyfill in theLoopbackPort-implementation, and that obviously isn't used anywhere within the various image decoders.At this point in time we've started to use
structuredClonea little bit more, hence it seems overall simpler to just bundle the polyfill even in thelegacy-version of the IMAGE_DECODERS built-target.