Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Node.js version on the bots #16403

Closed
Snuffleupagus opened this issue May 8, 2023 · 3 comments
Closed

Update the Node.js version on the bots #16403

Snuffleupagus opened this issue May 8, 2023 · 3 comments
Assignees
Labels

Comments

@Snuffleupagus
Copy link
Collaborator

In PR #16293 we increased the minimum supported Node.js version to 18, which is the current LTS version.
After that landed I noticed in the logs, see below, that the bots run older Node.js versions and that could become a problem (as we start using modern JS features).

@calixteman Can you please update the bots to Node.js version 18?

  • The Linux-bot now logs (at the start):
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: undefined,
npm WARN EBADENGINE   required: { node: '>=18' },
npm WARN EBADENGINE   current: { node: 'v16.16.0', npm: '8.11.0' }
npm WARN EBADENGINE }
...
  • The Windows-bot now logs (at the start):
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: undefined,
npm WARN EBADENGINE   required: { node: '>=18' },
npm WARN EBADENGINE   current: { node: 'v16.16.0', npm: '8.14.0' }
npm WARN EBADENGINE }
...
@calixteman
Copy link
Contributor

I updated node on the windows bot and it should be ok.
For the linux one, ubuntu version was too old (16.04), hence I began to upgrade it: so wait and see now.

@calixteman
Copy link
Contributor

Both bots are now using node 18.16.
I just triggered some tests:
#16397 (comment)

Likely we'll have some diffs on the linux bot: all the packages (and especially font ones) have been updated, hence I wouldn't surprised to see some differences.

@Snuffleupagus
Copy link
Collaborator Author

Seems to work; thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants