Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that addLinkAttributes is always called with a valid url parameter #11134

Merged
merged 1 commit into from
Sep 11, 2019
Merged

Ensure that addLinkAttributes is always called with a valid url parameter #11134

merged 1 commit into from
Sep 11, 2019

Commits on Sep 11, 2019

  1. Ensure that addLinkAttributes is always called with a valid url p… 

    …arameter

There's no good reason for calling this helper function without a `url` parameter, and this way we can prevent that from happening.
Note how the `PDFOutlineViewer` call-site was already doing the right thing here, and only the `LinkAnnotationElement` call-site needed a small adjustment to make it work.
    @Snuffleupagus
    Snuffleupagus committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    00efff5 View commit details
    Browse the repository at this point in the history