Ensure that addLinkAttributes
is always called with a valid url
parameter
#11134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no good reason for calling this helper function without a
url
parameter, and this way we can prevent that from happening.Note how the
PDFOutlineViewer
call-site was already doing the right thing here, and only theLinkAnnotationElement
call-site needed a small adjustment to make it work.Smaller diff with https://github.com/mozilla/pdf.js/pull/11134/files?w=1