Change 'save' button to 'upload' button #4963
Conversation
| @@ -6,6 +6,7 @@ contextMenuLabel = Take a Screenshot | |||
| myShotsLink = My Shots | |||
| screenshotInstructions = Drag or click on the page to select a region. Press ESC to cancel. | |||
| saveScreenshotSelectedArea = Save | |||
There was a problem hiding this comment.
If this string is unused, it should be removed from the file.
|
Why don't we ditch the string altogether and just use a title like on the other buttons? |
SGTM 👍 |
|
@6a68 i made a PR into your branch to remove the string from the upload button: |
|
I am not a big fan of removing the text, have we thought about going to opposite way, i.e adding "Save" etc. ? Even the titles on hover could be more descriptive, like "Save file to disk", "Upload to screenshots.firefox.com" |
|
@evilpie like the idea of having longer tooltips. I'm less enthusiastic about adding more text to buttons b/c localization will make the widths weird. I'll check in with our content strategy person and update strings. |
|
@johngruen Hmm. I fear that removing the text will take us from 'misleading button label' to 'inscrutable button label':
|
|
@6a68 not an hill i want to die on. We can keep the Upload text for a release and look at metrics to determine effects... R+, but can you change two colors in the sass variables file. |
|
Please also change the download button to "save", with an appropriate icon. Nothing is being downloaded here, it's a purely local operation (or should be, at least). |
Agreed. |
|
@johngruen Hmm. We could A/B test this label change, since it will change the core flow of the product. Might actually be a good exercise to get us prepared for the growth focus in Q1 of next year. How's that grab you? |
|
@schuetzm Thanks for the feedback, but I think it's actually much worse to change a button label to a different button, than it is to change the label to a new word. If you are used to the Screenshots convention that 'save' means 'upload', you are going to be unpleasantly surprised to discover 'save' suddenly means 'download'. |
That's a reasonable concern, and I generally agree, but not fixing the mistake because the mistake was made is a circular justification. Both of these buttons are misleading (and factually incorrect). Leaving one wrong because it's been wrong just prolongs the problem. Will it be acceptable to fix this later, after it's been mislabeled even longer? If anything, user confusion is precisely the reason this should be rectified as soon as possible (in fact, it would have avoided this new concern altogether had it been fixed when the privacy issue was first reported over a year ago). More directly: leaving the save button as "Download" generates confusion over the initial disposition of the image. If I can both Upload and Download the image, where is it? Is it being produced on Mozilla's server? Is it produced locally? A user can't be sure, because the language implies both and neither simultaneously. There is a standard convention for this sort of interface: local data may be saved from memory onto disk, or they may be uploaded to a remote location. The improved UI, even with this commit which addresses the privacy violation implications resulting from the mislabeled button, still doesn't adhere to this convention. I suppose that's a problem for a different PR, however. It's just a bit frustrating to see part of this poor UX persisting. |
|
@6a68 I strongly disagree with this; @Deledrius has explained the reasons very nicely. And I frankly find it quite disconcerting that it is necessary to argue about basic things like this. If making the additional changes takes too much time, then by all means just merge the PR now as-is, so that at least the worst privacy-related problem is fixed. But this mustn't be a justification not to tackle the other glaring problem immediately afterwards. |
|
Just for info: I am on Firefox 63 (Ubuntu 18.10), but this PR did not make it. |
|
Quick update: at least the official Windows x64 Firefox 66 package seems to miss this modification.
|
I think we were wrong to use 'Save' to mean 'Upload', and I don't recall why we went with it in the first place. It could seem like we're desperate to trick people into uploading shots. Let's not give that impression.