This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Fix #4338, fix regression in Library link #4343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit https://hg.mozilla.org/mozilla-central/diff/3182593eb59a/browser/base/content/utilityOverlay.js regressed this, requiring a principal for calls to openUILinkIn(). This changes that to the function openWebLinkIn() that provides a null principal.
gijsk
approved these changes
Apr 16, 2018
|
Otherwise you may want to "feature-test" for |
|
We're just riding the trains, so we should be good with no compatibility check. |
jaredhirsch
approved these changes
Apr 17, 2018
testeaxeax
pushed a commit
to testeaxeax/screenshots
that referenced
this pull request
Jun 7, 2018
…rvices#4343) The commit https://hg.mozilla.org/mozilla-central/diff/3182593eb59a/browser/base/content/utilityOverlay.js regressed this, requiring a principal for calls to openUILinkIn(). This changes that to the function openWebLinkIn() that provides a null principal.
testeaxeax
pushed a commit
to testeaxeax/screenshots
that referenced
this pull request
Jun 7, 2018
…zilla-services#4343)" This reverts commit a6dbfb4.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit https://hg.mozilla.org/mozilla-central/diff/3182593eb59a/browser/base/content/utilityOverlay.js regressed this, requiring a principal for calls to openUILinkIn(). This changes that to the function openWebLinkIn() that provides a null principal.
Note the relevant commit was by @jonathanKingston (r=@gijsk), but since he's not in this project I can't explicitly ask him for a review (though I'd take his review too ;)
I chose
openWebLinkIn()instead ofopenTrustedLinkIn(), because a lower permission principal seemed safer.