Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

The "Screnshots" button from the "Library" menu no longer works #4338

Closed
SoftVision-CosminMuntean opened this issue Apr 13, 2018 · 1 comment
Assignees
Labels
P1 [QA]:Blocker issue Label for QA to mark blocker issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues

Comments

@SoftVision-CosminMuntean

[Affected versions]:

  • Nightly 61.0a1
  • Screenshots 31.3.0 dev

[Affected Platforms]:

  • All Windows
  • All Mac
  • All Linux

[Prerequisites]:

  • The "xpinstall.signatures.required" boolean pref is set to "false".
  • The "extensions.legacy.enabled" boolean pref is set tot "true".
  • Have the Screenshots 31.3.0 dev version installed from here, on a new clean profile.

[Steps to reproduce]:

  1. Open the Firefox browser with the profile from prerequisites and navigate to any website.
  2. Click the "Library" button from the browser toolbar.
  3. Click the "Screenshots" button and observe the behaviour.

[Expected result]:

  • You are redirected to the "My Shots" page.

[Actual results]:

  • Nothing happens.

[Notes]:

  • The issue is not reproducible using Screenshots 31.1 production version from latest Nightly.

  • Here are the errors displayed in browser console:
    screenshots button from library

  • Here is a screen recording with the issue:
    screenshots button from library

@ghost ghost added this to the Sprint 10 (61-2) ⛅ milestone Apr 16, 2018
@ghost ghost assigned ianb Apr 16, 2018
@ghost ghost modified the milestones: Sprint 10 (61-2) ⛅, Sprint 11 (61-3) 👗 Apr 16, 2018
@ghost ghost added the P1 label Apr 16, 2018
ianb added a commit that referenced this issue Apr 16, 2018
The commit https://hg.mozilla.org/mozilla-central/diff/3182593eb59a/browser/base/content/utilityOverlay.js regressed this, requiring a principal for calls to openUILinkIn(). This changes that to the function openWebLinkIn() that provides a null principal.
@Softvision-CristinaBadescu

This issue is no longer reproducible using the latest Firefox Screenshots v32.0.0dev installed from here, on latest Nightly build 61.0a1 (2018-04-17) on Windows 10 x64, Mac 10.13.3 and Arch Linux 4.12. The "Screenshots" button from the "Library" menu redirects you to the "My Shots" page.

@SoftVision-CosminMuntean SoftVision-CosminMuntean added the [QA]:Verified fixed Label for QA to mark verified fixed issues label Apr 26, 2018
@SoftVision-CosminMuntean SoftVision-CosminMuntean added the [QA]:Blocker issue Label for QA to mark blocker issues logged label May 7, 2018
testeaxeax pushed a commit to testeaxeax/screenshots that referenced this issue Jun 7, 2018
…rvices#4343)

The commit https://hg.mozilla.org/mozilla-central/diff/3182593eb59a/browser/base/content/utilityOverlay.js regressed this, requiring a principal for calls to openUILinkIn(). This changes that to the function openWebLinkIn() that provides a null principal.
testeaxeax pushed a commit to testeaxeax/screenshots that referenced this issue Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P1 [QA]:Blocker issue Label for QA to mark blocker issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
Development

No branches or pull requests

3 participants