This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Add flake8 lint checking of python files #2393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standard8
force-pushed
the
enable-flake8
branch
from
1e69605
to
98e4af9
Compare
…nsions and get flake8 passing.
Standard8
force-pushed
the
enable-flake8
branch
from
98e4af9
to
a8974ef
Compare
ianb
approved these changes
Mar 15, 2017
| @@ -103,6 +104,14 @@ else | |||
| FIND_COMMAND := find -E $(GIT_EXPORT_DIR) | |||
| endif | |||
|
|
|||
| $(VENV): bin/require.pip | |||
| virtualenv -p python2.7 $(VENV) | |||
| . $(VENV)/bin/activate && pip install -r bin/require.pip | |||
There was a problem hiding this comment.
This could be $(VENV)/bin/pip install -r bin/require.pip
There was a problem hiding this comment.
This could be $(VENV)/bin/pip install -r bin/require.pip
Actually, that doesn't seem to work for pip install - looks like it needs the activation first.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2319 I'm creating a script that's going to use python (because that's currently the one language I can find a decent supported bugzilla API integration for).
Hence as part of that, we're going to need a .venv, and we might as well get flake8 set up as well to help with getting the scripts clean.