Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Check all shebangs for consistency #2394

Closed
pdehaan opened this issue Mar 15, 2017 · 0 comments
Closed

Check all shebangs for consistency #2394

pdehaan opened this issue Mar 15, 2017 · 0 comments

Comments

@pdehaan
Copy link
Collaborator

pdehaan commented Mar 15, 2017

In the spirit of #2393 (yay adding file extensions to scripts when possible), it'd probably be a good idea to quickly verify all the shebangs are correct in the ./bin/* files. I noticed in some places we do #!/bin/bash and in others we do #!/usr/bin/env bash:

$ git grep "#\!" bin

bin/_run-docker:#!/bin/bash
bin/build-docker-image:#!/usr/bin/env bash
bin/build-scripts/bundle_dependencies:#!/usr/bin/env bash
bin/build-scripts/css_to_js:#!/usr/bin/env python
bin/build-scripts/fixup_panel_js:#!/usr/bin/env python
bin/build-scripts/modularize:#!/usr/bin/env bash
bin/build-scripts/pontoon-to-webext.js:#! /usr/bin/env node
bin/build-scripts/set_file:#!/usr/bin/env bash
bin/build-scripts/sub_rdf_checkout_version:#!/usr/bin/env python
bin/build-scripts/update_manifest:#!/usr/bin/env python
bin/build-scripts/write_build_time:#!/usr/bin/env python
bin/build-scripts/write_ga_id:#!/usr/bin/env node
bin/clean-checkout:#!/usr/bin/env bash
bin/commit-new-version:#!/usr/bin/env bash
bin/dumpschema:#!/usr/bin/env bash
bin/generate-commit-log:#!/usr/bin/env python
bin/load_test_exercise.py:#!/usr/bin/env python
bin/make-data-url:#!/usr/bin/env python
bin/pg_vars:#!/usr/bin/env node
bin/release-version:#!/usr/bin/env bash
bin/run-addon:#!/bin/bash
bin/run-server:#!/bin/bash
bin/test-request:#!/usr/bin/env bash
@ianb ianb added this to the Stretch milestone Mar 15, 2017
@ghost ghost added the good first issue label Jun 28, 2017
@ianb ianb closed this as completed in 6c8c1d3 Aug 16, 2017
ianb added a commit that referenced this issue Aug 16, 2017
Fix #2394: make shebangs consistent
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants