This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Add missing bootstrap.js lifecycle functions #2350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdehaan
reviewed
Mar 10, 2017
| @@ -7,8 +7,8 @@ function startup(data, reason) { | |||
| }); | |||
| } | |||
|
|
|||
| function install() { | |||
| } | |||
| function shutdown(data, reason) {} | |||
There was a problem hiding this comment.
Q: Do we need to remove the listener that we added in startup() above during one of these lifecycle functions?
There was a problem hiding this comment.
Good question. That's not covered in the MDN docs for embedded webextensions, and to do so, we'd have to close over the browser object. I'm not sure if that's a good idea or not.
There are some bugs filed (#2332, #2333) around handling prefs to disable/enable the webextension, so maybe we can figure out the runtime.onMessage listener question there?
dannycoates
approved these changes
Mar 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2340.