Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Support extensions.%NAME%.disabled #2332

Closed
ghost opened this issue Mar 8, 2017 · 5 comments
Closed

Support extensions.%NAME%.disabled #2332

ghost opened this issue Mar 8, 2017 · 5 comments
Assignees

Comments

@ghost
Copy link

ghost commented Mar 8, 2017

%NAME% is simply whatever we decide to name this thing. Right now it's "pageshot".

Over in #2304 I talk about reporting the status of extensions.pageshot.disabled. This issue is to actually add and implement that preference. This preference should be relatively straight-forward. Check out my sweet pseudocode:

   # Somewhere in an init function:
   if extensions.pageshot.disabled == 1:
     return;

If extensions.pageshot.disabled is missing, we should enable as usual. The point of this pref is to bail as early as possible if it's not enabled so we don't use up any resources loading libraries and what not.

@ghost ghost added the beta blocker label Mar 8, 2017
@ghost ghost added this to the Page Shot in 54 milestone Mar 9, 2017
@jaredhirsch
Copy link
Member

We have to manually start the webextension from inside the bootstrap.js startup function, so, if the pref is set, we will not start the webextension. I think that should do it.

@ghost
Copy link
Author

ghost commented Mar 14, 2017

/cc @gregglind -- this is our plan for rolling out to users slowly in 54. Other than confirming the name of this pref and figuring out the rollout percentages, is there anything else we need to do to coordinate with a shield rollout?

/cc @Standard8 -- just to keep you in the loop. We're planning on shipping with the add-on enabled (according to firefox) but this pref set to 1 (disabled) so the add-on runs, but exits immediately, and then we'll slowly flip the pref off for folks so the feature rolls out.

@ianb ianb self-assigned this Mar 14, 2017
@ianb
Copy link
Contributor

ianb commented Mar 14, 2017

I'm going to name this extensions.pageshot.systemDisabled to make it clearer how it is different than #2333

Though the prefs will be controlled differently, they will have exactly the same effect. But some people will probably go into about:config and turn them both off just to be Extra Careful.

@ghost
Copy link
Author

ghost commented Mar 15, 2017

Sounds good. For the record, once we're done rolling this out (a couple weeks?) we can just remove this pref and the code for it altogether.

@jaredhirsch
Copy link
Member

Grabbing a few of these prefs / initialization / disabling bugs

@jaredhirsch jaredhirsch assigned jaredhirsch and unassigned ianb Mar 15, 2017
jaredhirsch pushed a commit that referenced this issue Mar 18, 2017
Other changes:

* Fix #2370, unset deviceId pref set by old addon.

* Update Promise rejection / Error handling to match behavior
  documented in the addons-related Gecko code.
jaredhirsch pushed a commit that referenced this issue Mar 18, 2017
Other changes:

* Fix #2370, unset deviceId pref set by old addon.

* Update Promise rejection / Error handling to match behavior
  documented in the addons-related Gecko code.
jaredhirsch pushed a commit that referenced this issue Mar 18, 2017
Other changes:

* Fix #2370, unset deviceId pref set by old addon.

* Update Promise rejection / Error handling to match behavior
  documented in the addons-related Gecko code.
jaredhirsch pushed a commit that referenced this issue Mar 18, 2017
Other changes:

* Fix #2370, unset deviceId pref set by old addon.

* Update Promise rejection / Error handling to match behavior
  documented in the addons-related Gecko code.
jaredhirsch pushed a commit that referenced this issue Mar 18, 2017
Other changes:

* Fix #2370, unset deviceId pref set by old addon.

* Update Promise rejection / Error handling to match behavior
  documented in the addons-related Gecko code.
@ianb ianb closed this as completed in b28d687 Mar 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants