Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Replace history.enabled pref with privacy API #4531

Closed
jaredhirsch opened this issue Jun 6, 2018 · 2 comments · Fixed by #4810
Closed

Replace history.enabled pref with privacy API #4531

jaredhirsch opened this issue Jun 6, 2018 · 2 comments · Fixed by #4810
Assignees
Labels
firefox Something that has to ship in the add-on in Firefox

Comments

@jaredhirsch
Copy link
Member

Related to #3875

We can replace the history.enabled pref check with this API:

https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/privacy/websites

@ghost ghost added the firefox Something that has to ship in the add-on in Firefox label Jun 7, 2018
@ghost ghost added this to the Sprint 15 (62-3) ⚽ milestone Jun 7, 2018
@jaredhirsch
Copy link
Member Author

Hmm. When the user goes into the prefs panel and sets history to "never remember", it turns out the places.history.enabled pref is not changed; its value remains true.

Similarly, trying to detect "never remember" by checking the value of browser.privacy.cookieConfig doesn't tell us what we want to know. In this case, the value is: { "behavior":"reject_third_party", "nonPersistentCookies":false }.

Next step is to figure out exactly which privacy settings break site auth, and how exactly to detect those via the webextension privacy.websites APIs (or request new APIs).

@ghost ghost assigned jaredhirsch Aug 2, 2018
@ghost ghost modified the milestones: Sprint 18 (63-2), Sprint 19 (63-3) Aug 2, 2018
@jaredhirsch
Copy link
Member Author

Closing in favor of #4773

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firefox Something that has to ship in the add-on in Firefox
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants