Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Replace pref checking with embedded experiment API #4533

Closed
jaredhirsch opened this issue Jun 7, 2018 · 3 comments
Closed

Replace pref checking with embedded experiment API #4533

jaredhirsch opened this issue Jun 7, 2018 · 3 comments
Assignees
Labels
firefox Something that has to ship in the add-on in Firefox

Comments

@jaredhirsch
Copy link
Member

The history.enabled pref can be checked via the privacy API (#4531), but other prefs should be checked via an embedded webextension API.

Related to #3875.

@ghost ghost added this to the Sprint 15 (62-3) ⚽ milestone Jun 7, 2018
@chenba chenba added the firefox Something that has to ship in the add-on in Firefox label Jun 22, 2018
@chenba chenba self-assigned this Jun 25, 2018
@chenba
Copy link
Collaborator

chenba commented Jun 26, 2018

I asked in #webextensions if WebExtension experiments would work if they are in an embedded extension, and kmag said "probably not". And that was my experience. The experiment API (browser.whateverExpierment) was undefined when I tried using it.

@ianb
Copy link
Contributor

ianb commented Jun 26, 2018

The add-on can run as a WebExtension instead of a bootstrap extension, I guess testable with ./bin/run-addon --webextension

That means we can test, though we can't incrementally deploy web experiment APIs until we're ready to turn off bootstrap entirely.

@ghost ghost assigned jaredhirsch Aug 2, 2018
@ghost ghost modified the milestones: Sprint 18 (63-2), Sprint 19 (63-3) Aug 2, 2018
@jaredhirsch
Copy link
Member Author

Closing in favor of #4773

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firefox Something that has to ship in the add-on in Firefox
Projects
None yet
Development

No branches or pull requests

5 participants