Updated streaming args for StreamingDataset subclasses #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when a StreamingFinetuningDataset is created using the build_finetuning_dataloader method, a failure is returned as some incorrect parameters are passed through to the constructor of StreamingFinetuningDataset. This patch fixes the paramter mismatch and adds test coverage for this case.
…streaming args, bumped streaming version
…streaming args, bumped streaming version
|
@snarayan21 do you need to update the pin in EDIT: Sorry, just didn't notice the setup.py change on my first skim :) |
dakinggg
reviewed
Sep 15, 2023
dakinggg
reviewed
Sep 16, 2023
There was a problem hiding this comment.
Thanks @snarayan21! Going to run regression tests just to make sure the upgrade doesn't break something unexpected.
|
Thanks for the patch! Probably should've checked the constructors in |
dakinggg
approved these changes
Sep 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the constructor for
StreamingFinetuningDatasetwas not updated with the correct streaming args, but thebuild_finetuning_dataloaderfunction that called it had some updated streaming args. This was causing errors upon dataset instantiation. This has been addressed.Additionally, the new streaming args
batching_methodandsampling_granularityhave been added toStreamingFinetuningDatasetandStreamingTextDataset.