Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py: replace composer with mosaicml #458

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

guoyejun
Copy link
Contributor

When we build mosaicml with "pip install -e .", we'll see package mosaicml is installed with link to the code tree of composer.

Without this change, we'll see package composer is again installed without link to the code tree of composer. mosaicml and composer are two different packages and llm-foundry will call into package composer which is not what we expect.

With this change, llm-foundry will call into the code tree of composer which is our expectation.

When we build mosaicml with "pip install -e .", we'll see package
mosaicml is installed with link to the code tree of composer.

Without this change, we'll see package composer is again installed
without link to the code tree of composer. mosaicml and composer
are two different packages and llm-foundry will call into package
composer which is not what we expect.

With this change, llm-foundry will call into the code tree of
composer which is our expectation.
@guoyejun
Copy link
Contributor Author

could not get the error detail at https://github.com/mosaicml/llm-foundry/actions/runs/5544247247/jobs/10128062038 (also copy below).

4m 7s
Run pre-commit run --all-files
[INFO] Initializing environment for https://github.com/google/yapf.
[INFO] Initializing environment for https://github.com/google/yapf:toml.
[INFO] Initializing environment for https://github.com/hadialqattan/pycln.
[INFO] Initializing environment for https://github.com/pycqa/isort.
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/Lucas-C/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/PyCQA/docformatter.
[INFO] Initializing environment for https://github.com/PyCQA/pydocstyle.
[INFO] Initializing environment for https://github.com/PyCQA/pydocstyle:toml.
[INFO] Initializing environment for https://github.com/adrienverge/yamllint.git.
[INFO] Initializing environment for https://github.com/trufflesecurity/trufflehog.git.
[INFO] Installing environment for https://github.com/google/yapf.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/hadialqattan/pycln.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pycqa/isort.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/Lucas-C/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/PyCQA/docformatter.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/PyCQA/pydocstyle.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/adrienverge/yamllint.git.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/trufflesecurity/trufflehog.git.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Error: The operation was canceled.

Copy link
Collaborator

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! We originally had the mosaicml package name, and recently got composer but haven't switched everything over yet.

The github action failure looks like a transient error... i'm not sure why. I tried rerunning it...

@mvpatel2000 mvpatel2000 merged commit 275fa56 into mosaicml:main Jul 14, 2023
10 checks passed
Michael-Pape added a commit to HeitechSoft/llm-foundry that referenced this pull request Jul 14, 2023
* Update mcli-hf-generate.yaml (mosaicml#456)

https://mosaicml.slack.com/archives/C056HNQ8XF1/p1689056584070479

* Add trust remote code for tokenizer in inference conversion script (mosaicml#446)

* add trust remote code for tokenizer

* lint

* lint

* setup.py: replace composer with mosaicml (mosaicml#458)

When we build mosaicml with "pip install -e .", we'll see package
mosaicml is installed with link to the code tree of composer.

Without this change, we'll see package composer is again installed
without link to the code tree of composer. mosaicml and composer
are two different packages and llm-foundry will call into package
composer which is not what we expect.

With this change, llm-foundry will call into the code tree of
composer which is our expectation.

---------

Co-authored-by: Vitaliy Chiley <6439018+vchiley@users.noreply.github.com>
Co-authored-by: Margaret Qian <ymqian@gmail.com>
Co-authored-by: Guo Yejun <yejun.guo@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants