-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setup.py: replace composer with mosaicml #458
Conversation
When we build mosaicml with "pip install -e .", we'll see package mosaicml is installed with link to the code tree of composer. Without this change, we'll see package composer is again installed without link to the code tree of composer. mosaicml and composer are two different packages and llm-foundry will call into package composer which is not what we expect. With this change, llm-foundry will call into the code tree of composer which is our expectation.
could not get the error detail at https://github.com/mosaicml/llm-foundry/actions/runs/5544247247/jobs/10128062038 (also copy below).
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! We originally had the mosaicml
package name, and recently got composer
but haven't switched everything over yet.
The github action failure looks like a transient error... i'm not sure why. I tried rerunning it...
* Update mcli-hf-generate.yaml (mosaicml#456) https://mosaicml.slack.com/archives/C056HNQ8XF1/p1689056584070479 * Add trust remote code for tokenizer in inference conversion script (mosaicml#446) * add trust remote code for tokenizer * lint * lint * setup.py: replace composer with mosaicml (mosaicml#458) When we build mosaicml with "pip install -e .", we'll see package mosaicml is installed with link to the code tree of composer. Without this change, we'll see package composer is again installed without link to the code tree of composer. mosaicml and composer are two different packages and llm-foundry will call into package composer which is not what we expect. With this change, llm-foundry will call into the code tree of composer which is our expectation. --------- Co-authored-by: Vitaliy Chiley <6439018+vchiley@users.noreply.github.com> Co-authored-by: Margaret Qian <ymqian@gmail.com> Co-authored-by: Guo Yejun <yejun.guo@intel.com>
When we build mosaicml with "pip install -e .", we'll see package mosaicml is installed with link to the code tree of composer.
Without this change, we'll see package composer is again installed without link to the code tree of composer. mosaicml and composer are two different packages and llm-foundry will call into package composer which is not what we expect.
With this change, llm-foundry will call into the code tree of composer which is our expectation.