Add trust remote code for tokenizer in inference conversion script #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
margaretqian
changed the title
dskhudia
approved these changes
Jul 10, 2023
|
@margaretqian : Thanks for adding this. |
Michael-Pape
added a commit
to HeitechSoft/llm-foundry
that referenced
this pull request
Jul 14, 2023
* Update mcli-hf-generate.yaml (mosaicml#456) https://mosaicml.slack.com/archives/C056HNQ8XF1/p1689056584070479 * Add trust remote code for tokenizer in inference conversion script (mosaicml#446) * add trust remote code for tokenizer * lint * lint * setup.py: replace composer with mosaicml (mosaicml#458) When we build mosaicml with "pip install -e .", we'll see package mosaicml is installed with link to the code tree of composer. Without this change, we'll see package composer is again installed without link to the code tree of composer. mosaicml and composer are two different packages and llm-foundry will call into package composer which is not what we expect. With this change, llm-foundry will call into the code tree of composer which is our expectation. --------- Co-authored-by: Vitaliy Chiley <6439018+vchiley@users.noreply.github.com> Co-authored-by: Margaret Qian <ymqian@gmail.com> Co-authored-by: Guo Yejun <yejun.guo@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to load locally downloaded checkpoints