Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove orig_params check #2981

Merged
merged 67 commits into from
May 16, 2024
Merged

remove orig_params check #2981

merged 67 commits into from
May 16, 2024

Commits on Feb 8, 2024

  1. remove orig_params check

    @milocress
    milocress committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    b276016 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. expect cpu-cpu test to fail

    @milocress
    milocress committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    c9fea5d View commit details
    Browse the repository at this point in the history

  2. expect cpu-cpu test to fail

    @milocress
    milocress committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    13ccb2b View commit details
    Browse the repository at this point in the history

  3. fix formatting

    @milocress
    milocress committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    3139b5c View commit details
    Browse the repository at this point in the history

  4. Merge branch 'dev' into milo/remove-orig-params-check

    @milocress
    milocress committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    03cbf4a View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Merge branch 'dev' into milo/remove-orig-params-check

    @milocress
    milocress committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    412a672 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Update test_checkpoint.py

    @milocress
    milocress committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    aea6ebd View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Merge branch 'dev' into milo/remove-orig-params-check

    @milocress
    milocress committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    8d65cfb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' into milo/remove-orig-params-check

    @milocress
    milocress committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    0fe6c1f View commit details
    Browse the repository at this point in the history

  3. expect True,True to succeed?

    @milocress
    milocress committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    faf8c71 View commit details
    Browse the repository at this point in the history

  4. remove commented code

    @milocress
    milocress committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    0939597 View commit details
    Browse the repository at this point in the history

  5. rerun tests

    @mvpatel2000
    mvpatel2000 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    80f79dc View commit details
    Browse the repository at this point in the history

  6. how about now

    @milocress
    milocress committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    f483dfb View commit details
    Browse the repository at this point in the history

  7. updated tests

    @milocress
    milocress committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    7ccac42 View commit details
    Browse the repository at this point in the history

  8. fix tests

    @milocress
    milocress committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    a01c954 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Update test_checkpoint.py

    @milocress
    milocress committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    ca3929f View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. WIP debugging

    @milocress
    milocress committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    dd7583c View commit details
    Browse the repository at this point in the history

  2. merged

    @milocress
    milocress committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    3da6a5f View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. wip debug

    @milocress
    milocress committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    469f31a View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Merge branch 'dev' into milo/remove-orig-params-check

    @milocress
    milocress committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    34ba1bd View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Merge branch 'dev' into milo/remove-orig-params-check

    @milocress
    milocress committed May 2, 2024
    Configuration menu
    Copy the full SHA
    bd71a66 View commit details
    Browse the repository at this point in the history

  2. Update test_checkpoint.py

    @milocress
    milocress committed May 2, 2024
    Configuration menu
    Copy the full SHA
    b6eea9c View commit details
    Browse the repository at this point in the history

  3. Update test_checkpoint.py

    @milocress
    milocress committed May 2, 2024
    Configuration menu
    Copy the full SHA
    6a8ff28 View commit details
    Browse the repository at this point in the history

  4. Update test_checkpoint.py

    @milocress
    milocress committed May 2, 2024
    Configuration menu
    Copy the full SHA
    43aa2d4 View commit details
    Browse the repository at this point in the history

  5. Update test_checkpoint.py

    @milocress
    milocress committed May 2, 2024
    Configuration menu
    Copy the full SHA
    7de12a2 View commit details
    Browse the repository at this point in the history

  6. Update test_checkpoint.py

    @milocress
    milocress committed May 2, 2024
    Configuration menu
    Copy the full SHA
    a38348f View commit details
    Browse the repository at this point in the history

  7. Update test_checkpoint.py

    @milocress
    milocress committed May 2, 2024
    Configuration menu
    Copy the full SHA
    b567fa9 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. WIP

    @milocress
    milocress committed May 7, 2024
    Configuration menu
    Copy the full SHA
    072844f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' into milo/remove-orig-params-check

    @mvpatel2000
    mvpatel2000 committed May 7, 2024
    Configuration menu
    Copy the full SHA
    3ba9215 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. counterexample is hanging guh

    @milocress
    milocress committed May 13, 2024
    Configuration menu
    Copy the full SHA
    7db4478 View commit details
    Browse the repository at this point in the history

  2. merged

    @milocress
    milocress committed May 13, 2024
    Configuration menu
    Copy the full SHA
    6e73f60 View commit details
    Browse the repository at this point in the history

  3. have repro

    @milocress
    milocress committed May 13, 2024
    Configuration menu
    Copy the full SHA
    2038088 View commit details
    Browse the repository at this point in the history

  4. less composer repro

    @milocress
    milocress committed May 13, 2024
    Configuration menu
    Copy the full SHA
    9945aaf View commit details
    Browse the repository at this point in the history

  5. found bug

    @milocress
    milocress committed May 13, 2024
    Configuration menu
    Copy the full SHA
    46c87b8 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. make counterexample match composer wrapper model situation

    @milocress
    milocress committed May 14, 2024
    Configuration menu
    Copy the full SHA
    d7c9879 View commit details
    Browse the repository at this point in the history

  2. still doesn't work

    @milocress
    milocress committed May 14, 2024
    Configuration menu
    Copy the full SHA
    3c28db9 View commit details
    Browse the repository at this point in the history

  3. update counterexample with printed models to show they're wrappped th… 

    …e same
    @milocress
    milocress committed May 14, 2024
    Configuration menu
    Copy the full SHA
    8e1457e View commit details
    Browse the repository at this point in the history

  4. trim unnecessary stuff

    @milocress
    milocress committed May 14, 2024
    Configuration menu
    Copy the full SHA
    d80d9da View commit details
    Browse the repository at this point in the history

  5. Merge branch 'dev' into milo/remove-orig-params-check

    @milocress
    milocress committed May 14, 2024
    Configuration menu
    Copy the full SHA
    5624b47 View commit details
    Browse the repository at this point in the history

  6. counterexample for the record

    @milocress
    milocress committed May 14, 2024
    Configuration menu
    Copy the full SHA
    a37962d View commit details
    Browse the repository at this point in the history

  7. simplified counterexample

    @milocress
    milocress committed May 14, 2024
    Configuration menu
    Copy the full SHA
    fdb681b View commit details
    Browse the repository at this point in the history

  8. fix tests

    @milocress
    milocress committed May 14, 2024
    Configuration menu
    Copy the full SHA
    e983170 View commit details
    Browse the repository at this point in the history

  9. fix quality and delete counterexample

    @milocress
    milocress committed May 14, 2024
    Configuration menu
    Copy the full SHA
    9789245 View commit details
    Browse the repository at this point in the history

  10. fix

    @milocress
    milocress committed May 14, 2024
    Configuration menu
    Copy the full SHA
    b213b92 View commit details
    Browse the repository at this point in the history

  11. asdict

    @milocress
    milocress committed May 14, 2024
    Configuration menu
    Copy the full SHA
    79fbed0 View commit details
    Browse the repository at this point in the history

  12. remove self (lol if only)

    @milocress
    milocress committed May 14, 2024
    Configuration menu
    Copy the full SHA
    cea4402 View commit details
    Browse the repository at this point in the history

  13. fix test

    @milocress
    milocress committed May 14, 2024
    Configuration menu
    Copy the full SHA
    01d18fa View commit details
    Browse the repository at this point in the history

  14. fix fix

    @milocress
    milocress committed May 14, 2024
    Configuration menu
    Copy the full SHA
    9eb1a35 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. fix

    @milocress
    milocress committed May 15, 2024
    Configuration menu
    Copy the full SHA
    4b430a8 View commit details
    Browse the repository at this point in the history

  2. reset save folder changes

    @milocress
    milocress committed May 15, 2024
    Configuration menu
    Copy the full SHA
    2d6aea9 View commit details
    Browse the repository at this point in the history

  3. remove meta for now

    @milocress
    milocress committed May 15, 2024
    Configuration menu
    Copy the full SHA
    37031b7 View commit details
    Browse the repository at this point in the history

  4. replace load_monolith_ with load_fsdp_monolith_

    @milocress
    milocress committed May 15, 2024
    Configuration menu
    Copy the full SHA
    049158f View commit details
    Browse the repository at this point in the history

  5. Merge branch 'dev' into milo/remove-orig-params-check

    @milocress
    milocress committed May 15, 2024
    Configuration menu
    Copy the full SHA
    b477bc3 View commit details
    Browse the repository at this point in the history

  6. change load_fsdp_monolith_rank0_only to load_monolith_rank0_only

    @milocress
    milocress committed May 15, 2024
    Configuration menu
    Copy the full SHA
    1c7d3c2 View commit details
    Browse the repository at this point in the history

  7. merged fsdp change

    @milocress
    milocress committed May 15, 2024
    Configuration menu
    Copy the full SHA
    6e0eac0 View commit details
    Browse the repository at this point in the history

  8. resolve conflicts?

    @milocress
    milocress committed May 15, 2024
    Configuration menu
    Copy the full SHA
    4507db1 View commit details
    Browse the repository at this point in the history

  9. expect failure when no sync module states

    @milocress
    milocress committed May 15, 2024
    Configuration menu
    Copy the full SHA
    33e007f View commit details
    Browse the repository at this point in the history

  10. fix constructor()

    @milocress
    milocress committed May 15, 2024
    Configuration menu
    Copy the full SHA
    a70e852 View commit details
    Browse the repository at this point in the history

  11. WIP

    @milocress
    milocress committed May 15, 2024
    Configuration menu
    Copy the full SHA
    aba4387 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'dev' into milo/remove-orig-params-check

    @milocress
    milocress committed May 15, 2024
    Configuration menu
    Copy the full SHA
    44e6f7f View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. WIP

    @milocress
    milocress committed May 16, 2024
    Configuration menu
    Copy the full SHA
    eb186f2 View commit details
    Browse the repository at this point in the history

  2. merged

    @milocress
    milocress committed May 16, 2024
    Configuration menu
    Copy the full SHA
    73e97b7 View commit details
    Browse the repository at this point in the history

  3. Update test_fsdp_checkpoint.py

    @mvpatel2000
    mvpatel2000 committed May 16, 2024
    Configuration menu
    Copy the full SHA
    40dc38b View commit details
    Browse the repository at this point in the history

  4. make PR ready for review

    @milocress
    milocress committed May 16, 2024
    Configuration menu
    Copy the full SHA
    115156a View commit details
    Browse the repository at this point in the history

  5. Merge branch 'dev' into milo/remove-orig-params-check

    @milocress
    milocress committed May 16, 2024
    Configuration menu
    Copy the full SHA
    c2d8b66 View commit details
    Browse the repository at this point in the history

  6. remove device

    @milocress
    milocress committed May 16, 2024
    Configuration menu
    Copy the full SHA
    cddb4c1 View commit details
    Browse the repository at this point in the history

  7. merged

    @milocress
    milocress committed May 16, 2024
    Configuration menu
    Copy the full SHA
    e1b7439 View commit details
    Browse the repository at this point in the history