Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove orig_params check #2981

Merged
merged 67 commits into from
May 16, 2024

Conversation

milocress
Copy link
Contributor

@milocress milocress commented Feb 8, 2024

What does this PR do?

Allows load_fsdp_monolith_rank0_only and use_orig_params to both be set to True - this was initially disabled due to a pytorch issue I think, but has since been resolved.

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@milocress milocress marked this pull request as ready for review March 20, 2024 17:52
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my entire career this is one of the best prs ive seen

@milocress milocress enabled auto-merge (squash) May 16, 2024 18:55
@milocress milocress merged commit 435c295 into mosaicml:dev May 16, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants