Improve type-widening and add tests #185
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
builds
performs type-widening when users specify targeted configs as default values. This prevents common friction with Hydra's validation system; see #84This PR fixes a case where the type-widening behavior was too aggressive: A targeted config type should not be broadened to
Any
since this is a valid type that can be leveraged by Hydra's runtime validation. Thus this PR fixes this, so that dataclass-types are retained and thus can be leveraged by Hydra for validation.Before:
After
This PR also ensures that type-widening is performed based on a configuration value after it has been processed by our sanitization functions. Currently, the only example that I could think of to actually exercise this distinction involves the functionality in #172 . The test I included will thus only exercise this aspect of this PR for sufficiently-old versions of omegaconf.