Patch upstream omegaconf issue #830 #172
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #170
For users using
omegaconf
2.1.1 or earlier, we provide a patch of an upstream bug.Before:
After:
We achieve this by detecting the particular conditions for which this bug occurs:
omegaconf
, where this bug is fixedand only under these circumstances will we automatically transform
to
which ensures that the resulting config will instantiate as-expected.
We provide this automatic support for all use-cases of
make_config
andbuilds
. We cannot provide this automatic support forhydrated_dataclass
, however we do still detect the conditions and raise aHydraZenValidationError
in such circumstances.