Don't show "in progress" lines when not writing to a TTY #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigfe
force-pushed
the
check-if-isatty
branch
from
a8e4fad
to
000c4fa
Compare
|
This includes a test that forces the old behaviour ( |
|
Sample of the OCaml-CI output using this PR: Much nicer 🙂 |
craigfe
force-pushed
the
check-if-isatty
branch
2 times, most recently
from
9d32724
to
23a36a6
Compare
|
Will merge at the end of the week, unless there are objections. |
craigfe
force-pushed
the
check-if-isatty
branch
from
23a36a6
to
857e873
Compare
samoht
approved these changes
Aug 26, 2020
|
CI failures unrelated (and known about upstream), so merging. |
craigfe
added a commit
to craigfe/opam-repository
that referenced
this pull request
Aug 26, 2020
…lwt (1.2.2) CHANGES: - Fail gracefully when the user supplies an empty suite name. (mirage/alcotest#265, @craigfe) - Fix compatibility with `fmt.0.8.8+dune` by adding a missing `fmt` dependency in `alcotest`'s dune file (mirage/alcotest#266, @NathanReb) - Only show "in progress" lines when writing to a TTY. (mirage/alcotest#267, @craigfe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Alcotest output is currently quite hard to read when printed to CI logs. For instance, in OCaml-CI:
Partly this is because colours have been lost, but mostly it's due to emitting
\rcharacters when not printing to a TTY. This PR disables the "..." lines when isatty returnsfalse.