Explicitly declare Alcotest's deps on fmt #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was transitively working thanks to fmt.tty with the upstream fmt version but trying to use fmt's dune port failed.
NathanReb
force-pushed
the
declare-fmt-deps
branch
from
0fc83a2
to
019ed53
Compare
|
Ta 🙂 |
craigfe
approved these changes
Aug 10, 2020
craigfe
added a commit
to craigfe/opam-repository
that referenced
this pull request
Aug 26, 2020
…lwt (1.2.2) CHANGES: - Fail gracefully when the user supplies an empty suite name. (mirage/alcotest#265, @craigfe) - Fix compatibility with `fmt.0.8.8+dune` by adding a missing `fmt` dependency in `alcotest`'s dune file (mirage/alcotest#266, @NathanReb) - Only show "in progress" lines when writing to a TTY. (mirage/alcotest#267, @craigfe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was transitively working thanks to fmt.tty with the upstream fmt version but trying to use fmt's dune port failed.