Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extra repls added when debugging js #178607

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Conversation

connor4312
Copy link
Member

If a child session is shut down or shutting down, don't detach it from its parent.

Fixes #173993

Requires microsoft/vscode-js-debug#1619 to work reliably

If a child session is shut down or shutting down, don't detach it from its parent.

Fixes #173993

Requires microsoft/vscode-js-debug#1619 to work reliably
@connor4312 connor4312 self-assigned this Mar 29, 2023
@connor4312 connor4312 enabled auto-merge (squash) March 29, 2023 18:24
@vscodenpa vscodenpa added this to the April 2023 milestone Mar 29, 2023
@connor4312 connor4312 merged commit 99aaa65 into main Mar 29, 2023
@connor4312 connor4312 deleted the connor4312/issue173993 branch March 29, 2023 19:17
trbot86 pushed a commit to trbot86/vscode that referenced this pull request Mar 29, 2023
If a child session is shut down or shutting down, don't detach it from its parent.

Fixes microsoft#173993

Requires microsoft/vscode-js-debug#1619 to work reliably
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Psuedo targets are added to the "Select Debug Console" dropdown when an attached JS target is restarted
3 participants